From 5fa104db69b2308c6c814fca2f35aa428615e87e Mon Sep 17 00:00:00 2001 From: Pavel Baksy Date: Fri, 26 Dec 2025 02:09:01 +0100 Subject: [PATCH] Remove incorrect HTTPie dependency from documentation HTTPie was listed as a dependency but the application actually uses libsoup3 from GNOME Platform. Updated README to reflect correct dependencies and removed installation instructions for HTTPie. Also corrected code comments to reference libsoup3 instead of HTTPie. --- README.md | 12 +++--------- src/http_client.py | 4 ++-- src/models.py | 2 +- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 4043286..d772922 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ A modern HTTP client for GNOME, built with GTK 4 and libadwaita. - GTK 4 - libadwaita 1 - Python 3 -- HTTPie (http command) +- libsoup3 (provided by GNOME Platform) ## Building @@ -27,12 +27,6 @@ sudo meson install -C builddir ## Usage -Roster uses HTTPie as the backend for making HTTP requests. Ensure HTTPie is installed: +Roster uses libsoup3 (from GNOME Platform) for making HTTP requests - no external dependencies required. -```bash -pip install httpie -# or on Fedora -sudo dnf install httpie -``` - -Then run Roster from your application menu or with the `roster` command. +Run Roster from your application menu or with the `roster` command. diff --git a/src/http_client.py b/src/http_client.py index 287f10c..eef9819 100644 --- a/src/http_client.py +++ b/src/http_client.py @@ -150,7 +150,7 @@ class HttpClient: status_code = msg.get_status() status_text = msg.get_reason_phrase() - # Format headers like HTTPie output (HTTP/1.1 200 OK\nHeader: value\n...) + # Format headers in HTTPie-style output (HTTP/1.1 200 OK\nHeader: value\n...) headers_text = self._format_headers(msg, status_code, status_text) # Decode body with error handling @@ -166,7 +166,7 @@ class HttpClient: def _format_headers(self, msg: Soup.Message, status_code: int, status_text: str) -> str: """ - Format response headers to match HTTPie output format. + Format response headers in HTTPie-style output format. Format: HTTP/1.1 200 OK diff --git a/src/models.py b/src/models.py index 8385c15..a01dae1 100644 --- a/src/models.py +++ b/src/models.py @@ -48,7 +48,7 @@ class HttpResponse: """Represents an HTTP response.""" status_code: int status_text: str # e.g., "OK" - headers: str # Raw header text from HTTPie + headers: str # Raw header text from libsoup3 body: str # Raw body text response_time_ms: float